Fix building on M1 macOS #1910
Merged
Fix building on M1 macOS #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I installed this package with the command below. I am still getting this error npm install Automattic/node-canvas#m1 |
|
This PR fixes the issue I'd reported in #1923, thanks!
|
zbjornson
approved these changes
Nov 11, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change JPEG detection to go thru pkg-config.
I also needed to add the new homebrew directory to the gif part in order for it to pick up giflib. I did try to also add
/no/folder/hereto see that it doesn't error out if the folder doesn't exists, and that seems to work.That being said, it would be great if some people can try this out on different operating systems!
fixes #1839 #1733